Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test of missing verifier in cli context #5618

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Add test of missing verifier in cli context #5618

merged 2 commits into from
Feb 6, 2020

Conversation

antho1404
Copy link
Contributor

@antho1404 antho1404 commented Feb 6, 2020 •
edited
Loading

Description

When creating a CLI context with no trusted node and no verifier, the /block/xxx is crashing. This PR adds a test to make sure that the verifier is present; if not, it returns an error.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #5618 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5618      +/-   ##
==========================================
- Coverage   53.43%   53.42%   -0.01%     
==========================================
  Files         322      322              
  Lines       19748    19750       +2     
==========================================
  Hits        10552    10552              
- Misses       8379     8381       +2     
  Partials      817      817
Impacted Files Coverage Δ
client/context/query.go 1.86% <0%> (-0.04%) ⬇️

alexanderbez
alexanderbez approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ++

@alexanderbez alexanderbez merged commit b0c6c75 into cosmos:master Feb 6, 2020
@antho1404 antho1404 deleted the bug/missing-verifier branch February 7, 2020 05:28
@alessio alessio mentioned this pull request Mar 20, 2020
Closed
13 tasks
alexanderbez pushed a commit that referenced this pull request Mar 24, 2020
@antho1404 @alexanderbez
Merge PR #5618: Add test of missing verifier in cli context
f096e0f
@jgimeno jgimeno mentioned this pull request Apr 9, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antho1404 @alexanderbez